| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Aug 2014 13:39:28 -0700 From: Kamal Mostafa <kamal@...onical.com> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org, kernel-team@...ts.ubuntu.com Cc: Peter Zijlstra <peterz@...radead.org>, David Miller <davem@...emloft.net>, Chris Metcalf <cmetcalf@...era.com>, James Bottomley <James.Bottomley@...senpartnership.com>, Vineet Gupta <vgupta@...opsys.com>, Jason Low <jason.low2@...com>, Waiman Long <waiman.long@...com>, "James E.J. Bottomley" <jejb@...isc-linux.org>, Paul McKenney <paulmck@...ux.vnet.ibm.com>, John David Anglin <dave.anglin@...l.net>, James Hogan <james.hogan@...tec.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Davidlohr Bueso <davidlohr@...com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Catalin Marinas <catalin.marinas@....com>, Russell King <linux@....linux.org.uk>, Will Deacon <will.deacon@....com>, linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, sparclinux@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, Kamal Mostafa <kamal@...onical.com> Subject: [PATCH 3.13 145/259] locking/mutex: Disable optimistic spinning on some architectures 3.13.11.6 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Zijlstra <peterz@...radead.org> commit 4badad352a6bb202ec68afa7a574c0bb961e5ebc upstream. The optimistic spin code assumes regular stores and cmpxchg() play nice; this is found to not be true for at least: parisc, sparc32, tile32, metag-lock1, arc-!llsc and hexagon. There is further wreckage, but this in particular seemed easy to trigger, so blacklist this. Opt in for known good archs. Signed-off-by: Peter Zijlstra <peterz@...radead.org> Reported-by: Mikulas Patocka <mpatocka@...hat.com> Cc: David Miller <davem@...emloft.net> Cc: Chris Metcalf <cmetcalf@...era.com> Cc: James Bottomley <James.Bottomley@...senpartnership.com> Cc: Vineet Gupta <vgupta@...opsys.com> Cc: Jason Low <jason.low2@...com> Cc: Waiman Long <waiman.long@...com> Cc: "James E.J. Bottomley" <jejb@...isc-linux.org> Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com> Cc: John David Anglin <dave.anglin@...l.net> Cc: James Hogan <james.hogan@...tec.com> Cc: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Davidlohr Bueso <davidlohr@...com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> Cc: Catalin Marinas <catalin.marinas@....com> Cc: Russell King <linux@....linux.org.uk> Cc: Will Deacon <will.deacon@....com> Cc: linux-arm-kernel@...ts.infradead.org Cc: linux-kernel@...r.kernel.org Cc: linuxppc-dev@...ts.ozlabs.org Cc: sparclinux@...r.kernel.org Link: http://lkml.kernel.org/r/20140606175316.GV13930@laptop.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@...nel.org> Signed-off-by: Kamal Mostafa <kamal@...onical.com> --- arch/arm/Kconfig | 1 + arch/arm64/Kconfig | 1 + arch/powerpc/Kconfig | 1 + arch/sparc/Kconfig | 1 + arch/x86/Kconfig | 1 + kernel/Kconfig.locks | 5 ++++- 6 files changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 31e1f44..b3d400d 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -6,6 +6,7 @@ config ARM select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_HAVE_CUSTOM_GPIO_H select ARCH_MIGHT_HAVE_PC_PARPORT + select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_USE_CMPXCHG_LOCKREF select ARCH_WANT_IPC_PARSE_VERSION select BUILDTIME_EXTABLE_SORT if MMU diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 6d4dd22..bf0ed5d 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -2,6 +2,7 @@ config ARM64 def_bool y select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select ARCH_USE_CMPXCHG_LOCKREF + select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_WANT_OPTIONAL_GPIOLIB select ARCH_WANT_COMPAT_IPC_PARSE_VERSION select ARCH_WANT_FRAME_POINTERS diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index b44b52c..ab43fa3 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -139,6 +139,7 @@ config PPC select OLD_SIGACTION if PPC32 select HAVE_DEBUG_STACKOVERFLOW select HAVE_IRQ_EXIT_ON_IRQ_STACK + select ARCH_SUPPORTS_ATOMIC_RMW config GENERIC_CSUM def_bool CPU_LITTLE_ENDIAN diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 6c95f4d..94cd9c1 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -76,6 +76,7 @@ config SPARC64 select ARCH_HAVE_NMI_SAFE_CMPXCHG select HAVE_C_RECORDMCOUNT select NO_BOOTMEM + select ARCH_SUPPORTS_ATOMIC_RMW config ARCH_DEFCONFIG string diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 9e31880..9562fc3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -125,6 +125,7 @@ config X86 select RTC_LIB select HAVE_DEBUG_STACKOVERFLOW select HAVE_IRQ_EXIT_ON_IRQ_STACK if X86_64 + select ARCH_SUPPORTS_ATOMIC_RMW config INSTRUCTION_DECODER def_bool y diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks index d2b32ac..ecee67a 100644 --- a/kernel/Kconfig.locks +++ b/kernel/Kconfig.locks @@ -220,6 +220,9 @@ config INLINE_WRITE_UNLOCK_IRQRESTORE endif +config ARCH_SUPPORTS_ATOMIC_RMW + bool + config MUTEX_SPIN_ON_OWNER def_bool y - depends on SMP && !DEBUG_MUTEXES + depends on SMP && !DEBUG_MUTEXES && ARCH_SUPPORTS_ATOMIC_RMW -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists