linux-kernel - Re: [PULL REQUEST] i2c for 3.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFy0UVY=60pCr85AvhedfO-MEoD-iMGdWmBYt8fKgF7kWA@mail.gmail.com>
Date:	Sat, 9 Aug 2014 10:34:44 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Wolfram Sang <wsa@...-dreams.de>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Lan Tianyu <tianyu.lan@...el.com>
Cc:	linux-i2c@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PULL REQUEST] i2c for 3.17

On Sat, Aug 9, 2014 at 6:56 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
>
> here is the pull request for 3.17 for the I2C subsystem. Highlights:

Lowlight: selecting ACPI support (which used to be the default if ACPI
was enabled) now forces i2c to be built-in.

I've pulled this, but it's broken. You need to fix it someway.

The reason for this is

  config I2C
         tristate "I2C support"
  ...
  config I2C_ACPI
         bool "I2C ACPI support"
         select I2C
         depends on ACPI
   ...

where if I2C_APCI is on (y), then that "select I2C" will cause I2C to
be upgraded to 'y' as well.

This seems to be intentional, judging by the commit message, but it's
wrong. Distributions etc generally compile i2c as a module, and you've
now broken that.

This is a regression. Change the "select I2C" to a "depends on I2C",
and test the end result. Don't force people to build things into the
kernel.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/