linux-kernel - Re: [PATCH] vfio: Fix build failure seen if vfio is built as module and EEH is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53E6A078.6040907@roeck-us.net>
Date:	Sat, 09 Aug 2014 15:28:08 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Alex Williamson <alex.williamson@...hat.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gavin Shan <gwshan@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] vfio: Fix build failure seen if vfio is built as module
 and EEH is enabled

On 08/09/2014 12:28 PM, Alex Williamson wrote:
> On Sat, 2014-08-09 at 10:04 -0700, Guenter Roeck wrote:
>> The following build failure is seen with ppc:allmodconfig.
>>
>> ERROR: ".vfio_spapr_iommu_eeh_ioctl" [drivers/vfio/vfio_iommu_spapr_tce.ko] undefined!
>> ERROR: ".vfio_spapr_pci_eeh_open" [drivers/vfio/pci/vfio-pci.ko] undefined!
>> ERROR: ".vfio_spapr_pci_eeh_release" [drivers/vfio/pci/vfio-pci.ko] undefined!
>>
>> Simply exporting the missing symbols is insufficient, since drivers/vfio
>> can be built as module but drivers/vfio/vfio_spapr_eeh.c depends on
>> EEH which is boolean. The combination of obj-m for drivers/vfio and obj-y
>> for drivers/vfio/vfio_spapr_eeh.o results in the symbols being missed even
>> if exported.
>>
>> Export missing symbols and introduce new tristate configuration option
>> VFIO_EEH depending on both EEH and VFIO to fix the problem.
>>
>> Cc: Gavin Shan <gwshan@...ux.vnet.ibm.com>
>> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> Please try:
>
> git://github.com/awilliam/linux-vfio.git next
>
> This will be part of the next linux-next build, should resolve the
> problem, and I plan to ask for a pull early this coming week.  Thanks,
>

That should do for the most part, but it will select VFIO_SPAPR_EEH
even if EEH is not configured. You would need something like
	select VFIO_SPAPR_EEH if (PPC_POWERNV || PPC_PSERIES) && EEH
to prevent that.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/