linux-kernel - Re: [patch 119/197] scripts/coccinelle/free: Delete NULL test before freeing functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53E5DA60.90902@users.sourceforge.net>
Date:	Sat, 09 Aug 2014 10:22:56 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Coccinelle <cocci@...teme.lip6.fr>
CC:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Fabian Frederick <fabf@...net.be>,
	Joe Perches <joe@...ches.com>
Subject: Re: [patch 119/197] scripts/coccinelle/free: Delete NULL test before
 freeing functions

> +@r depends on context || report || org @
> +expression E;
> +position p;
> +@@
> +
> +* if (E)
> +*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);

How do you think about to add the construct "@p" also behind the function name
"usb_free_urb"?


Is my previous update suggestion for such an issue worth for another look, too?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/