linux-kernel - Re: Runtime trouble with commit dbd952127d (seccomp: introduce writer locking)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140810193308.GA31867@redhat.com>
Date:	Sun, 10 Aug 2014 21:33:08 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Guenter Roeck <private@...ck-us.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andy Lutomirski <luto@...capital.net>
Subject: Re: Runtime trouble with commit dbd952127d (seccomp: introduce
	writer locking)

On 08/09, Kees Cook wrote:
>
> On Sat, Aug 9, 2014 at 6:47 PM, Guenter Roeck <private@...ck-us.net> wrote:
> > Hi folks,
> >
> > I am having some trouble with commit dbd952127d (seccomp: introduce
> > writer locking) when running my qemu tests on the upstream kernel.
>
> Eek, sorry this is causing you trouble!
>
> > With powerpc, I get the following crash.
> >
> > ftrace: allocating 20093 entries in 59 pages
> > ------------[ cut here ]------------
> > kernel BUG at kernel/fork.c:1108!
>
> For your tree, does this resolve to copy_seccomp()'s
>
>         BUG_ON(!spin_is_locked(&current->sighand->siglock));
>
> line?

This is almost off-topic, and I too do not understand whats going on...

But I'd suggest to change this check to use  lockdep_is_held() in any
case.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/