linux-kernel - Re: [PATCH] staging: soc_camera.c: fixed coding style: lines over 80 char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1407704449.4082.11.camel@joe-AO725>
Date:	Sun, 10 Aug 2014 14:00:49 -0700
From:	Joe Perches <joe@...ches.com>
To:	Suman Kumar <suman@...orcecomputing.com>
Cc:	hverkuil@...all.nl, g.liakhovetski@....de, m.chehab@...sung.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: soc_camera.c: fixed coding style: lines over
 80 char

On Mon, 2014-08-11 at 02:11 +0530, Suman Kumar wrote:
>     Fixes a coding style issue of 'lines over 80 char' reported by
>     checkpatch.pl
[]
> diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
[]
> @@ -1430,7 +1434,7 @@ static int soc_camera_async_bound(struct v4l2_async_notifier *notifier,
>  				  struct v4l2_async_subdev *asd)
>  {
>  	struct soc_camera_async_client *sasc = container_of(notifier,
> -					struct soc_camera_async_client, notifier);
> +				    struct soc_camera_async_client, notifier);
>  	struct soc_camera_device *icd = platform_get_drvdata(sasc->pdev);

I don't easily parse the original or modified lines.

If you are really concerned abut 80 columns and readability
instead of merely quieting checkpatch, these might be better
on multiple lines like

	struct soc_camera_async_client *sasc;
	struct soc_camera_device *icd;

	sasc = container_of(notifier, struct soc_camera_async_client, notifier);
	icd = platform_get_drvdata(sasc->pdev);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/