linux-kernel - Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53E70DB4.4000606@cn.fujitsu.com>
Date:	Sun, 10 Aug 2014 14:14:12 +0800
From:	tangchen <tangchen@...fujitsu.com>
To:	<akpm@...ux-foundation.org>, <santosh.shilimkar@...com>,
	<grygorii.strashko@...com>, <phacht@...ux.vnet.ibm.com>,
	<yinghai@...nel.org>, <fabf@...net.be>,
	<Emilian.Medve@...escale.com>, Xishi Qiu <qiuxishi@...wei.com>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<tangchen@...fujitsu.com>
Subject: Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().

Sorry, add Xishi Qiu <qiuxishi@...wei.com>

On 08/10/2014 02:12 PM, Tang Chen wrote:
> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
> be phys_addr_t because it is used to store the return value from
> __memblock_find_range_bottom_up().
>
> The bug has not been triggered because when allocating low memory near
> the kernel end, the "int ret" won't turn out to be minus. When we started
> to allocate memory on other nodes, and the "int ret" could be minus.
> Then the kernel will panic.
>
> A simple way to reproduce this: comment out the following code in numa_init(),
>
>          memblock_set_bottom_up(false);
>
> and the kernel won't boot.
>
> Reported-by: Xishi Qiu <qiuxishi@...wei.com>
> Signed-off-by: Tang Chen <tangchen@...fujitsu.com>
> ---
>   mm/memblock.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 6d2f219..70fad0c 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -192,8 +192,7 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
>   					phys_addr_t align, phys_addr_t start,
>   					phys_addr_t end, int nid)
>   {
> -	int ret;
> -	phys_addr_t kernel_end;
> +	phys_addr_t kernel_end, ret;
>   
>   	/* pump up @end */
>   	if (end == MEMBLOCK_ALLOC_ACCESSIBLE)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/