lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 9 Aug 2014 21:27:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Adrian Remonda <adrianremonda@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Larry.Finger@...inger.net
Subject: Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote:
> On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote:
> > This patch clear some code that was not doing any help.
> > Pointed out by Larry.Finger
> > 
> 
> The patch is fine but the changelog doesn't inpsire confidence.  It
> should say:
> 
> This patch removes some unneeded code.
> 1) kzalloc() allocates 4 extra bytes so that we can align the return
>    value.  But actually the return value is already aligned so we can
>    remove the + 4 and the call to N_BYTE_ALIGMENT().
> 2) The memset() isn't needed because kzalloc() zeroes the allocation.
> 
> Suggested-by: Larry Finger <Larry.Finger@...inger.net>

Adrian, can you please fix this up and resend the series based on Dan's
comments?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists