linux-kernel - Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140810042549.GA20106@kroah.com>
Date:	Sat, 9 Aug 2014 21:25:49 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Miguel Oliveira <cmroliv@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol
 sparse warning

On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote:
> Fix sparse warning:
> drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
> by making it static since it's only used once.
> 
> Signed-off-by: Miguel Oliveira <cmroliv@...il.com>
> ---
>  drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> index 7fa744b..d2bcc16 100644
> --- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> @@ -22,7 +22,7 @@
>  #define		ODM_TXPWRTRACK_MAX_IDX_88E		6
>  
>  
> -u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
> +static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
>  {
>  	u8	channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
>  		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,

Someone else made this change already, always work against the
linux-next tree :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/