linux-kernel - Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140811073408.GA16504@dhcp-27-160.brq.redhat.com>
Date:	Mon, 11 Aug 2014 09:34:08 +0200
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Jayamohan Kallickal <Jayamohan.Kallickal@...lex.Com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact()
 instead of pci_enable_msix()

On Mon, Jul 28, 2014 at 11:29:51PM +0000, Jayamohan Kallickal wrote:
> 
> 
> -----Original Message-----
> From: Alexander Gordeev [mailto:agordeev@...hat.com] 
> Sent: Saturday, July 26, 2014 1:09 AM
> To: linux-kernel@...r.kernel.org; Jayamohan Kallickal
> Subject: Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()
> 
> On Wed, Jul 16, 2014 at 08:05:05PM +0200, Alexander Gordeev wrote:
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers using these 
> > two interfaces need to be updated to use the new 
> > pci_enable_msi_range()  or pci_enable_msi_exact() and 
> > pci_enable_msix_range() or pci_enable_msix_exact() interfaces.
> 
> Hi Jayamohan,
> 
> Could you please review this patch?

Jayamohan?

> Thanks!
> 
> > Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> > ---
> >  drivers/scsi/be2iscsi/be_main.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/scsi/be2iscsi/be_main.c 
> > b/drivers/scsi/be2iscsi/be_main.c index 56467df..1f63169 100644
> > --- a/drivers/scsi/be2iscsi/be_main.c
> > +++ b/drivers/scsi/be2iscsi/be_main.c
> > @@ -5278,12 +5278,10 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba)
> >  	for (i = 0; i <= phba->num_cpus; i++)
> >  		phba->msix_entries[i].entry = i;
> >  
> > -	status = pci_enable_msix(phba->pcidev, phba->msix_entries,
> > -				 (phba->num_cpus + 1));
> > +	status = pci_enable_msix_exact(phba->pcidev, phba->msix_entries,
> > +				       phba->num_cpus + 1);
> >  	if (!status)
> >  		phba->msix_enabled = true;
> > -
> > -	return;
> >  }
> >  
> >  static void be_eqd_update(struct beiscsi_hba *phba)
> > --
> > 1.7.7.6
> > 
> 
> 
> Looks Good.
> 
> Acked-by:  Jayamohan Kallickal <jayamohan.kallickal@...lex.com>
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/