linux-kernel - Re: [PATCH] perf script: Fix possible memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87vbpzfp0a.fsf@sejong.aot.lge.com>
Date:	Mon, 11 Aug 2014 16:45:41 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH] perf script: Fix possible memory leaks

Hi Adrian,

On Fri, 01 Aug 2014 14:32:19 +0300, Adrian Hunter wrote:
> On 1/08/2014 11:24 a.m., Namhyung Kim wrote:
>> Some paths in perf script don't call perf_session__delete() after
>> creating a new session.
>>

[SNIP]
>> -	perf_session__delete(session);
>>   	cleanup_scripting();
>> +out_delete:
>> +	perf_session__delete(session);
>
> Some of the db-export scripting I do relies on the session
> being deleted before the script is stopped.  I would prefer
> the original order i.e. perf_session__delete() then
> cleanup_scripting()

Okay, I'll fix it and send v2.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/