lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Aug 2014 10:32:19 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Javier Martinez Canillas <javier.martinez@...labora.co.uk> Cc: Doug Anderson <dianders@...omium.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Nick Dyer <nick.dyer@...ev.co.uk>, Stephen Warren <swarren@...dia.com>, Yufeng Shen <miletus@...omium.org>, Benson Leung <bleung@...omium.org>, Olof Johansson <olof@...om.net>, Tomasz Figa <tomasz.figa@...il.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Thomas Abraham <thomas.ab@...sung.com> Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c? Or else I'm not really following this... $SUBJECT is a bit confusing. On Sat, Aug 9, 2014 at 12:26 AM, Javier Martinez Canillas <javier.martinez@...labora.co.uk> wrote: > Regardless of this though I think that both the patch to move the IRQ > pinmux setup from .irq_set_type to the .irq_request_resources and the patch to > to prevent any pinmux reconfiguration are good improvements to avoid future > issues like the one we found here. I think someone should look into switching the Samsung/Exynos pinctrl driver to the gpiolib irqchip helpers, I looked at it but was scared by the special wkup chip and stuff I can't test. The irqchip helpers will atleast help out in flagging GPIO lines as used for IRQs so the core can keep track of stuff and show that properly in debugfs. The orthogonality compliance between GPIO and irqchip must however be solved in the driver itself, the core only helps out in blocking some abuse of the API. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists