linux-kernel - Re: [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140811091437.GA2730@katana>
Date:	Mon, 11 Aug 2014 11:14:37 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Mark D Rustad <mrustad@...il.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Peter Hurley <peter@...leysoftware.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: ti-st: st_kim.c:  Cleaning up missing
 null-terminate after strncpy call


> > 	strncpy(kim_data->dev_name, buf, count);
> > +	kim_data->dev_name[count - 1] = '\n';
> 
> Of course this does not add termination, but adds a newline at the end of the buffer? Huh?

strlcpy?


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)