linux-kernel - Re: [PATCH] staging: lustre: lustre: obdclass: genops.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140811105550.GM4856@mwanda>
Date:	Mon, 11 Aug 2014 13:55:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Hongchao Zhang <hongchao.zhang@...el.com>,
	Peng Tao <bergwolf@...il.com>,
	Alex Zhuravlev <alexey.zhuravlev@...el.com>,
	linux-kernel@...r.kernel.org, Ann Koehler <amk@...y.com>,
	Christoph Jaeger <email@...istophjaeger.info>,
	Lisa Nguyen <lisa@...apiadmin.com>
Subject: Re: [PATCH] staging: lustre: lustre: obdclass: genops.c: Cleaning up
 missing null-terminate after strncpy call

On Sun, Aug 10, 2014 at 01:48:00AM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
> 

No.  This one isn't needed.  The static checker *should* know this so it
is a problem with the static checker and not with the code.

Don't change code, just because the static checker has problems.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/