linux-kernel - Re: [PATCH] gpiolib: Don't allow drivers to specify a base with DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140811123146.GA17528@sirena.org.uk>
Date:	Mon, 11 Aug 2014 13:31:46 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linaro-kernel <linaro-kernel@...ts.linaro.org>
Subject: Re: [PATCH] gpiolib: Don't allow drivers to specify a base with DT

On Mon, Aug 11, 2014 at 09:26:49AM +0200, Linus Walleij wrote:
> On Thu, Jul 31, 2014 at 2:07 PM, Mark Brown <broonie@...nel.org> wrote:

> > -       if (base < 0) {
> > +       if (base < 0 || of_have_populated_dt()) {
> >                 base = gpiochip_find_base(chip->ngpio);

> But here I worry about breaking in-transition systems, e.g.
> defining part of the peripherals through DT but adding a
> GPIO device with AUXDATA, setting up base that way.

> Not that it should stay that way for sure, but it does need
> some consideration...

Could we add a flag that the boards can use to override this behaviour?

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)