[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140811110745.GJ11899@mwanda>
Date: Mon, 11 Aug 2014 15:54:22 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Srikrishan Malik <srikrishanmalik@...il.com>,
Joe Perches <joe@...ches.com>, greg@...ah.com,
andreas.dilger@...el.com, oleg.drokin@...el.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace
warnings
On Mon, Aug 11, 2014 at 04:27:06PM +0530, Srikrishan Malik wrote:
> This patch set is aimed at removing checkpatch issues from files in
> lustre/lustre/mdc.
>
> Is it ok if I just fix those in this set and post another patch set
> to take care of other issues identified in review?
checkpatch fixes are worthless if they don't make the code better for
human readers.
>
> - removing typedef for ldlm_policy_data_t will touch many other
> files/dirs which were not initially targeted for this patch set.
Yeah. You're right. This should be done in a separate patch because
it doesn't completely fall under the "cleanup variable declarations in
mdc_enqueue()" header.
> - There can be a separate patch to remove __u64.
It's all part of the same thing "variable declarations in that
function."
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists