linux-kernel - Re: [PATCH] xen_hvc: no reason to write the type key on xenstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1408111532020.2293@kaball.uk.xensource.com>
Date:	Mon, 11 Aug 2014 15:32:48 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	<xen-devel@...ts.xensource.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Dave Scott <Dave.Scott@...citrix.com>,
	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<jslaby@...e.cz>
Subject: Re: [PATCH] xen_hvc: no reason to write the type key on xenstore

CC'ing tty maintainers.

On Mon, 11 Aug 2014, Stefano Stabellini wrote:
> The backend type is chosen by the toolstack. Regardless, the frontend
> should not care, especially given that it cannot have an effect as the
> backend is started before this code is run.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> 
> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> index 636c9ba..b8491f5 100644
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev,
> 			    evtchn);
> 	if (ret)
> 		goto error_xenbus;
> -	ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu");
> -	if (ret)
> -		goto error_xenbus;
> 	ret = xenbus_transaction_end(xbt, 0);
> 	if (ret) {
> 		if (ret == -EAGAIN)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/