linux-kernel - Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140811144238.GA10029@mail.corp.redhat.com>
Date:	Mon, 11 Aug 2014 10:42:38 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM

On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> 
> > If CONFIG_PM is not set:
> > 
> > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > not used
> > 
> > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> Thanks Geert.
> 
> hid-wacom is in a sort of temporary mode of operation, being moved from 
> Input to HID driver.
> 
> Adding Benjamin and Dmitry to CC, as this will likely still go through 
> Dmitry's queue.
> 

Thanks for fixing this Geert.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/