linux-kernel - Re: [PATCH 1/2] arm64: compat: wire up memfd_create and getrandom syscalls for aarch32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4SyoMEXa7dX8PdYUckBJzL3V+FzZSoKUKqsgGnzPAVbFg@mail.gmail.com>
Date:	Mon, 11 Aug 2014 18:55:50 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Will Deacon <will.deacon@....com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm64: compat: wire up memfd_create and getrandom
 syscalls for aarch32

Hi

On Mon, Aug 11, 2014 at 3:37 PM, Will Deacon <will.deacon@....com> wrote:
> arch/arm/ just grew support for the new memfd_create and getrandom
> syscalls, so add them to our compat layer too.
>
> Signed-off-by: Will Deacon <will.deacon@....com>
> ---
>  arch/arm64/include/asm/unistd.h   | 2 +-
>  arch/arm64/include/asm/unistd32.h | 5 +++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h
> index 4bc95d27e063..6d2bf419431d 100644
> --- a/arch/arm64/include/asm/unistd.h
> +++ b/arch/arm64/include/asm/unistd.h
> @@ -41,7 +41,7 @@
>  #define __ARM_NR_compat_cacheflush     (__ARM_NR_COMPAT_BASE+2)
>  #define __ARM_NR_compat_set_tls                (__ARM_NR_COMPAT_BASE+5)
>
> -#define __NR_compat_syscalls           383
> +#define __NR_compat_syscalls           386
>  #endif
>
>  #define __ARCH_WANT_SYS_CLONE
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index e242600c4046..da1f06b535e3 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -787,3 +787,8 @@ __SYSCALL(__NR_sched_setattr, sys_sched_setattr)
>  __SYSCALL(__NR_sched_getattr, sys_sched_getattr)
>  #define __NR_renameat2 382
>  __SYSCALL(__NR_renameat2, sys_renameat2)
> +                       /* 383 for seccomp */

No idea what happens if you increase __NR_compat_syscalls without
adding __SYSCALL(). Apart from that, it's the same I have in my
private memfd-branch, so fine with me (I will then drop my
arm64-compat patch for memfd).

Thanks
David

> +#define __NR_getrandom 384
> +__SYSCALL(__NR_getrandom, sys_getrandom)
> +#define __NR_memfd_create 385
> +__SYSCALL(__NR_memfd_create, sys_memfd_create)
> --
> 2.0.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/