linux-kernel - Re: [PATCH] Made bpf_internal_load_pointer_neg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407794456.12335.3.camel@oc1318858833.ibm.com>
Date:	Mon, 11 Aug 2014 15:00:56 -0700
From:	Benjamin Lee <leeben@...ux.vnet.ibm.com>
To:	davem@...emloft.net, linux-kernel@...r.kernel.org
Cc:	dany@...ibm.com, dany4madden@...il.com, benjamin.fik.lee@...il.com
Subject: Re: [PATCH] Made bpf_internal_load_pointer_neg_helper static:
 fixes Sparse warning

I wanted to know what the current status of my patch is since my
internship will be ending this Friday and I want to know before then. if
there are any problems with it I can fix them before Thursday. Thank you
in advance.

On Fri, 2014-07-18 at 11:34 -0700, Benjamin Lee wrote:
> This patch fixes the following Sparse warning:
> 
> net/core/filter.c:52:6: warning: symbol
> 'bpf_internal_load_pointer_neg_helper' was not declared. Should it be
> static?
> 
> I declared bpf_internal_load_pointer_neg_helper as static because it  
> is not referenced elsewhere in the kernel. The patched kernel boots  
> and runs OK. I verified that the section of code is actually being  
> compiled by temporarily placing a #pragma message inside the function.  
> I also verified that the function is being called by temporarily  
> inserting a call to panic.
> 
> I am a high school student trying to become familiar with the open  
> source process and the Linux kernel, so your guidance is appreciated.
> 
> Signed-off-by Benjamin Lee <leeben@...ux.vnet.ibm.com>
> Reviewed-by: Dany Madden <danymadden@...ibm.com>
> Reviewed-by: Jim Keniston <jkenisto@...ibm.com>
> 
> ---
>   net/core/filter.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 735fad8..068442a 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -70,7 +70,8 @@
>    *
>    * Exported for the bpf jit load helper.
>    */
> -void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
> +static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb,
> +                                                 int k, unsigned int
> size)
>   {
>         u8 *ptr = NULL;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/