linux-kernel - Re: [alsa-devel] [PATCH] ASoC: wm8962: Correct the bit offset to enable mono speaker output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 09:24:16 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Peter Chan <peter.chan@...escale.com>
Cc:	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"tiwai@...e.de" <tiwai@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	"shengjiu.wang@...escale.com" <shengjiu.wang@...escale.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	Nicolin Chen <nicoleotsuka@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"guangyu.chen@...escale.com" <guangyu.chen@...escale.com>,
	"rf@...nsource.wolfsonmicro.com" <rf@...nsource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8962: Correct the bit offset to
	enable mono speaker output

On Mon, Aug 11, 2014 at 02:19:49PM +0100, Charles Keepax wrote:
> On Fri, Aug 08, 2014 at 09:55:43AM +0000, Peter Chan wrote:
> > 
> > But our customer reported that they did try to set both SPKOUTR_ENA and SPKOUTL_ENA bits in mono mode but the sound is lousy. If setting SPKOUTR_ENA alone, the speaker has no sound. Only setting SPKOUTL_ENA bit get the correct speaker output in mono mode.
> 
> From the wording of "tie both outputs together" in the datasheet
> I would assume that means both should be fed the same audio? Was
> this done? I will try to give the hardware guys here a shout and
> see if I can get some clarification on mono mode on this device.

I have had a word with the hardware team here and both channels
do need to be enabled but audio should only be fed to the left
channel. So the driver definitely needs updated for the mono
case, but I am unclear as to what is causing your poor audio
quality issue.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/