linux-kernel - Re: [PATCH] ASoC: wm8994: register irq handler for mic1 detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 12:48:49 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nikesh Oswal <nikesh@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8994: register irq handler for mic1 detect

On Tue, Aug 12, 2014 at 12:43:49PM +0100, Nikesh Oswal wrote:

> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -4099,6 +4099,15 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
>  				dev_warn(codec->dev,
>  					 "Failed to request Mic1 detect IRQ: %d\n",
>  					 ret);
> +		} else {
> +			ret = wm8994_request_irq(wm8994->wm8994,
> +					WM8994_IRQ_MIC1_DET,
> +					wm8994_mic_irq, "Mic 1 detect",
> +					wm8994);
> +			if (ret != 0)
> +				dev_warn(codec->dev,
> +				"Failed to request Mic1 detect IRQ: %d\n",
> +				ret);

This need a better changelog and possibly some editing of the code to
make it clearer.  According to the above diff we're in the else case for
an if statement where the true path also requests the same interrupt (or
at least something with the same text reported in the error message).

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)