[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1408121628090.15220@pobox.suse.cz>
Date: Tue, 12 Aug 2014 16:28:44 +0200 (CEST)
From: Jiri Kosina <jkosina@...e.cz>
To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
cc: Himangi Saraogi <himangi774@...il.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Archana Patni <archana.patni@...ux.intel.com>,
Jonathan Cameron <jic23@...nel.org>,
linux-kernel@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] HID: hid-sensor-hub: use devm_ functions consistently
On Sat, 2 Aug 2014, Srinivas Pandruvada wrote:
> > Use devm_kzalloc for all calls to kzalloc and not just the first. Use
> > devm functions for other allocations as well. The calls to free the
> > allocated memory in the probe and remove functions are done away with
> > and a label is removed in the probe function.
> >
> > The semantic match that finds the inconsistency is as follows:
> >
> > // <smpl>
> > @@
> > @@
> >
> > *devm_kzalloc(...)
> > ...
> > *kzalloc(...)
> > // </smpl>
> >
> > Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> > Acked-by: Julia Lawall <julia.lawall@...6.fr>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
Queued for 3.17, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists