linux-kernel - Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1A7F74DC-3922-4626-BDDF-E8E6C90C221C@linuxhacker.ru>
Date:	Mon, 11 Aug 2014 22:02:54 -0400
From:	Oleg Drokin <green@...uxhacker.ru>
To:	Oleg Drokin <oleg.drokin@...el.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Benedict Boerger <benedict.boerger@...tu-dortmund.de>,
	<linux-kernel@...r.kernel.org>, <devel@...verdev.osuosl.org>,
	<andreas.dilger@...el.com>
Subject: Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function


On Aug 11, 2014, at 9:58 PM, Oleg Drokin wrote:

> 
> On Aug 10, 2014, at 12:34 AM, Greg KH wrote:
>> Very odd, with this patch applied, I now get a build warning:
>> 
>> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’:
>> drivers/staging/lustre/lnet/lnet/config.c:1193:2: warning: ‘ipaddrs’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>> lnet_ipaddr_free_enumeration(ipaddrs, nip);
>> ^
> 
> What's even more odd is that the very previous line also uses ipaddrs, yet it does not trigger the warning.
> In any case I believe it's a false positive, since the only way it could remain unitialized is if
> libcfs_ipif_enumerate returned negative value (stored in nif in this function) and we check for it being more than zero
> before getting to that part of code.
> 
> I'll submit a patch assigning ipaddrs to NULL as a workaround shortly.

Err, looking at the wrong function there, it's lnet_ipaddr_enumerate that returns negative if ipaddrs was not changed.
Anyway still false positive.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/