linux-kernel - Re: [PATCH v2 08/13] staging: lustre: fix multi line strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140812174211.GA27354@mordor>
Date:	Tue, 12 Aug 2014 23:12:11 +0530
From:	Srikrishan Malik <srikrishanmalik@...il.com>
To:	"Drokin, Oleg" <oleg.drokin@...el.com>
Cc:	"<greg@...ah.com>" <greg@...ah.com>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/13] staging: lustre: fix multi line strings

On Tue, Aug 12, 2014 at 02:17:07AM +0000, Drokin, Oleg wrote:
> 
> On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote:
> 
> > Fixes the following checkpatch warning:
> > 
> > WARNING: quoted string split across lines
> 
> > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c b/drivers/staging/lustre/lustre/mdc/mdc_request.c
> > index 57d903156917..6c691a4763b5 100644
> > --- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
> > +++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
> > @@ -2055,8 +2055,8 @@ static int mdc_hsm_copytool_send(int len, void *val)
> > 		return -EPROTO;
> > 	}
> > 
> > -	CDEBUG(D_HSM, " Received message mg=%x t=%d m=%d l=%d actions=%d "
> > -	       "on %s\n",
> > +	CDEBUG(D_HSM,
> > +	       " Received message mg=%x t=%d m=%d l=%d actions=%d on %s\n",
> > 	       lh->kuc_magic, lh->kuc_transport, lh->kuc_msgtype,
> > 	       lh->kuc_msglen, hal->hal_count, hal->hal_fsname);
> 
> I imagine we can drop the leading space here as well.

ok, I will resend this patch including the suggested change.
I was not sure if we can do this in single patch.

> 
> Thanks.
> 
> Bye,
>     Oleg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/