linux-kernel - Re: [PATCH RFC 0/4] VFS revoke()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140812191444.GW18016@ZenIV.linux.org.uk>
Date:	Tue, 12 Aug 2014 20:14:45 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	David Herrmann <dh.herrmann@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, linux-fsdevel@...r.kernel.org,
	Theodore Tso <tytso@....edu>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH RFC 0/4] VFS revoke()

On Tue, Aug 12, 2014 at 08:54:04PM +0200, David Herrmann wrote:

> Open questions:
>  * Obviously, we need to protect all calls into file->f_op->xyz(). This series
>    provides enter_file() and leave_file() that can be used like:
>       if (enter_file(file))
>           retval = file->f_op->xyz(file, ...);
>       else
>           retval = -ENODEV;
>    Question is, should we do this at the time we actually invoke those
>    callbacks or should we do it at the syscall-entry time?

The former, obviously.  The real bitch is around mmap - you don't need
that for evdev, but generic solution would better deal with that kind
of crap.

I'll post a review once I'm done with Eric's patchset; hopefully tonight or
tomorrow morning.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/