linux-kernel - Re: [PATCH v3 5/7] arm: kgdb: Handle read-only text / modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJiGXJQ4Bdu9Mhvj=jCdZ76w6_OOYoCmYEJZ47=HHSptg@mail.gmail.com>
Date:	Tue, 12 Aug 2014 12:40:55 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Laura Abbott <lauraa@...eaurora.org>,
	Liu hua <sdu.liu@...wei.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Tomasz Figa <t.figa@...sung.com>,
	Jason Wessel <jason.wessel@...driver.com>,
	Will Deacon <will.deacon@....com>,
	Doug Anderson <dianders@...omium.org>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Doug Anderson <dianders@...gle.com>,
	Rabin Vincent <rabin@....in>,
	Nikolay Borisov <Nikolay.Borisov@....com>,
	Mark Salter <msalter@...hat.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 5/7] arm: kgdb: Handle read-only text / modules

On Tue, Aug 12, 2014 at 12:38 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> On 08/12/14 11:24, Kees Cook wrote:
>> @@ -244,6 +248,32 @@ void kgdb_arch_exit(void)
>>       unregister_die_notifier(&kgdb_notifier);
>>  }
>>
>> +int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
>> +{
>> +     int err;
>> +
>> +     /* patch_text() only supports int-sized breakpoints */
>> +     if (sizeof(int) != BREAK_INSTR_SIZE)
>> +             return -EINVAL;
>
> Could this be a BUILD_BUG_ON too?

Ah yes, good call. I'll adjust that.

Thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/