linux-kernel - Re: [PATCH v2] regulator: Add stub for devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140812215515.GC17528@sirena.org.uk>
Date:	Tue, 12 Aug 2014 22:55:15 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Rob Clark <robdclark@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] regulator: Add stub for devm_regulator_get_exclusive

On Tue, Aug 12, 2014 at 09:37:09AM +0800, Axel Lin wrote:
> Fix below build error when !CONFIG_REGULATOR.
> 
>   CC      drivers/gpu/drm/msm/hdmi/hdmi.o
> drivers/gpu/drm/msm/hdmi/hdmi.c: In function 'hdmi_init':
> drivers/gpu/drm/msm/hdmi/hdmi.c:126:3: error: implicit declaration of function 'devm_regulator_get_exclusive' [-Werror=implicit-function-declaration]

So, I just looked at that driver - it errors out on probe without the
regualtor.  Are you sure the fix isn't to add a dependency on the
regulator API or convert it back to using normal regulator gets (it was
converted without comment as part of a DT conversion), or indeed to
using the bulk regulator API.  It looks awfully like the driver is just
open coding devm_regulator_bulk_get() and friends.

There is no explanation at all in either the changelog or the code for
why the driver is asking for exclusive regulators.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)