linux-kernel - Re: [PATCH -next] extcon: fix extcon-sm5502 build when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <53EB1681.9040602@samsung.com>
Date:	Wed, 13 Aug 2014 16:40:49 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH -next] extcon: fix extcon-sm5502 build when CONFIG_I2C=m

Dear Randy,

Thanks for your report.

I catched this issue. So, I fix this bug already. You can check it on following url:
- http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-test&id=5e519b04db6c5b42f8d8ee246c16903c130b5fd5


Best Regards,
Chanwoo Choi

On 08/13/2014 04:22 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors in extcon-sm5502.c by making EXTCON_SM5502 depend
> on I2C since it selects REGMAP_I2C.  The build errors happen when
> CONFIG_I2C=m and CONFIG_EXTCON_SM5502=y. This Kconfig change causes
> CONFIG_EXTCON_SM5502 to be =m when CONFIG_I2C=m.
> 
> drivers/built-in.o: In function `regmap_smbus_byte_reg_read':
> regmap-i2c.c:(.text+0x5030a): undefined reference to `i2c_smbus_read_byte_data'
> drivers/built-in.o: In function `regmap_smbus_byte_reg_write':
> regmap-i2c.c:(.text+0x50338): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `regmap_smbus_word_reg_read':
> regmap-i2c.c:(.text+0x50356): undefined reference to `i2c_smbus_read_word_data'
> drivers/built-in.o: In function `regmap_smbus_word_reg_write':
> regmap-i2c.c:(.text+0x50384): undefined reference to `i2c_smbus_write_word_data'
> drivers/built-in.o: In function `regmap_i2c_read':
> regmap-i2c.c:(.text+0x503cf): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `regmap_i2c_gather_write':
> regmap-i2c.c:(.text+0x50442): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `regmap_i2c_write':
> regmap-i2c.c:(.text+0x50474): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `sm5502_muic_i2c_init':
> extcon-sm5502.c:(.init.text+0x6630): undefined reference to `i2c_register_driver'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc:	Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux-next-20140813/drivers/extcon/Kconfig
> ===================================================================
> --- linux-next-20140813.orig/drivers/extcon/Kconfig
> +++ linux-next-20140813/drivers/extcon/Kconfig
> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>  
>  config EXTCON_SM5502
>  	tristate "SM5502 EXTCON support"
> +	depends on I2C
>  	select IRQ_DOMAIN
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/