linux-kernel - Re: [PATCH 1/7] staging: dgap: remove useless variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140813092246.GT11899@mwanda>
Date:	Wed, 13 Aug 2014 12:22:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	DaeSeok Youn <daeseok.youn@...il.com>
Cc:	Lidza Louina <lidza.louina@...il.com>,
	Mark Hounschell <markh@...pro.net>,
	devel <devel@...verdev.osuosl.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] staging: dgap: remove useless variable

On Tue, Aug 12, 2014 at 09:28:13AM +0900, DaeSeok Youn wrote:
> Hi, Dan
> 
> 2014-08-11 19:56 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
> > On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
> >> dgap_major_serial_registered and dgap_major_transparent_print_registered
> >> could be checked whether a board is initialized.
> >> But it doesn't need to check that variables becasue dgap module
> >> isn't calling the dgap_cleanup_tty() without initializing
> >> for a board completely.
> >
> > I don't understand.  What about the call to dgap_cleanup_module() in
> > dgap_init_module()?
> I think the call of dgap_cleanup_tty()
> in dgap_cleanup_module() from dgap_init_module() is not reached.
> Because dgap_init_module() is called when driver is loaded, at this
> point of time,
> there are no boards that are initialized.(dgap_numboards is zero)
> 
> And the change log of this is needed to modify for clearing message.

Ah.  Ok.  Thanks for the explanation.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/