lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1407926840-8576-1-git-send-email-nikesh@opensource.wolfsonmicro.com>
Date:	Wed, 13 Aug 2014 11:47:20 +0100
From:	Nikesh Oswal <nikesh@...nsource.wolfsonmicro.com>
To:	broonie@...nel.org, lgirdwood@...il.com
Cc:	perex@...ex.cz, tiwai@...e.de, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

wm_hubs is a common driver code shared by WM8958, WM1811, WM8944
and WM8993 all these codecs have the DC Servo Values either in register
57h or 59h. Current code was reading register 58h for WM8958 and WM8994
revisions 2 and 3 but looking at the data sheet the DC Servo Values are
stored in register 57h for these codecs. This patch fixes it by reading
the correct register for DC Servo

Signed-off-by: Nikesh Oswal <nikesh@...nsource.wolfsonmicro.com>
---
 sound/soc/codecs/wm_hubs.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/wm_hubs.c b/sound/soc/codecs/wm_hubs.c
index 916817f..95c5d71 100644
--- a/sound/soc/codecs/wm_hubs.c
+++ b/sound/soc/codecs/wm_hubs.c
@@ -210,9 +210,6 @@ static int wm_hubs_read_dc_servo(struct snd_soc_codec *codec,
 	case 2:
 		dcs_reg = WM8994_DC_SERVO_4E;
 		break;
-	case 1:
-		dcs_reg = WM8994_DC_SERVO_READBACK;
-		break;
 	default:
 		dcs_reg = WM8993_DC_SERVO_3;
 		break;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ