| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Aug 2014 13:02:19 +0200
From: Antonios Motakis <a.motakis@...tualopensystems.com>
To: alex.williamson@...hat.com, kvmarm@...ts.cs.columbia.edu,
iommu@...ts.linux-foundation.org
Cc: tech@...tualopensystems.com, a.rigo@...tualopensystems.com,
kvm@...r.kernel.org, christoffer.dall@...aro.org,
will.deacon@....com, kim.phillips@...escale.com,
stuart.yoder@...escale.com, eric.auger@...aro.org,
marc.zyngier@....com,
Antonios Motakis <a.motakis@...tualopensystems.com>,
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH 4/4] VFIO: PLATFORM: DEVTREE: Return arrays of u32, u16, or u8
Certain properties of a device tree node are accessible as an array
of unsigned integers, either u32, u16, or u8. Let the VFIO user query
this type of device node properties.
Signed-off-by: Antonios Motakis <a.motakis@...tualopensystems.com>
---
drivers/vfio/platform/devtree.c | 99 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/drivers/vfio/platform/devtree.c b/drivers/vfio/platform/devtree.c
index 80c60d4..331cc34 100644
--- a/drivers/vfio/platform/devtree.c
+++ b/drivers/vfio/platform/devtree.c
@@ -98,6 +98,96 @@ static int devtree_get_full_name(struct device_node *np, void __user *datap,
return 0;
}
+static int devtree_get_u32_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u32 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u32));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u32) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u32), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u32_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u32)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
+static int devtree_get_u16_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u16 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u16));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u16) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u16), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u16_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u16)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
+static int devtree_get_u8_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u8 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u8));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u8) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u8), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u8_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u8)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
long vfio_platform_devtree_ioctl(struct vfio_platform_device *vdev,
unsigned long arg)
{
@@ -143,6 +233,15 @@ long vfio_platform_devtree_ioctl(struct vfio_platform_device *vdev,
} else if (info.type == VFIO_DEVTREE_ARR_TYPE_STRING)
ret = devtree_get_strings(vdev->of_node, name, datap, datasz);
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U32)
+ ret = devtree_get_u32_arr(vdev->of_node, name, datap, datasz);
+
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U16)
+ ret = devtree_get_u16_arr(vdev->of_node, name, datap, datasz);
+
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U8)
+ ret = devtree_get_u8_arr(vdev->of_node, name, datap, datasz);
+
kfree(name);
out:
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists