linux-kernel - Re: question regarding drivers/staging/rtl8821ae/rtl8821ae/dm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140813020109.GA4973@kroah.com>
Date:	Wed, 13 Aug 2014 10:01:09 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: question regarding drivers/staging/rtl8821ae/rtl8821ae/dm.c

On Wed, Aug 13, 2014 at 01:06:16AM +0530, Himangi Saraogi wrote:
> Hi,
> 
> In the file, I see the code:
> 
> void rtl8821ae_dm_set_tx_ant_by_tx_
> info(...) {
>   ...
>   if ((rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) ||
>       (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)){
>      SET_TX_DESC_TX_ANT(pdesc, pfat_table->antsel_a[mac_id]);
>   }
> }
> 
> Here, there is a double test. It seems the second test must be for
> CGCS_RX_HW_ANTDIV or CG_TRX_SMART_ANTDIV but am not sure. Is the second test
> just redundant or a different constant must be used?

No idea, try asking the original developers of the code (hint, almost
impossible...)

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/