linux-kernel - Re: [Patch V2 1/3] staging: android: ion: ion_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Aug 2014 16:15:05 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Phong Tran <tranmanphong@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	swetland@...gle.com, linux-kernel@...r.kernel.org,
	ccross@...roid.com, joe@...ches.com, akpm@...ux-foundation.org
Subject: Re: [Patch V2 1/3] staging: android: ion: ion_dummy_driver.c Fix
 coding style

On Wed, Aug 13, 2014 at 08:09:38PM +0700, Phong Tran wrote:
> This patch fix checkpatch.pl warning
> - Replace kzalloc() by kcalloc()
> Tested by compilation.
> 

The patches look ok, but can you resend with better subject lines?
kzalloc() -> kcalloc().
add blank.
remove returns.

Something like that.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/