lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1407996100-6359-4-git-send-email-namhyung@kernel.org> Date: Thu, 14 Aug 2014 15:01:40 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Arnaldo Carvalho de Melo <acme@...nel.org> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>, Ingo Molnar <mingo@...nel.org>, Paul Mackerras <paulus@...ba.org>, Namhyung Kim <namhyung.kim@....com>, Namhyung Kim <namhyung@...nel.org>, LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>, Andi Kleen <andi@...stfloor.org>, Frederic Weisbecker <fweisbec@...il.com>, Arun Sharma <asharma@...com>, Rodrigo Campos <rodrigo@...g.com.ar> Subject: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries The "perf report -g" displays callchains callee-first order. That means it can see the callers of the sample in a reverse order. For example, "intel_idle" entry shows following callchain on my data. Children Self Command Shared Object Symbol -------- -------- --------------- ------------------ ---------------- 40.53% 40.53% swapper [kernel.kallsyms] [k] intel_idle | --- intel_idle cpuidle_enter cpuidle_wrap_enter cpuidle_enter_tk cpuidle_idle_call cpu_idle | |--85.25%-- start_secondary | --14.75%-- rest_init start_kernel x86_64_start_reservations x86_64_start_kernel So "intel_idle" was called by "cpuidle_enter", and in turn, it's called by "cpuidle_wrap_enter" and so on. When with -g "caller", it shows callchains in a reversed order - "caller-first". I know it's sometimes useful but never used it. 40.53% 40.53% swapper [kernel.kallsyms] [k] intel_idle | |--85.25%-- start_secondary | cpu_idle | cpuidle_idle_call | cpuidle_enter_tk | cpuidle_wrap_enter | cpuidle_enter | intel_idle | --14.75%-- x86_64_start_kernel x86_64_start_reservations start_kernel rest_init cpu_idle cpuidle_idle_call cpuidle_enter_tk cpuidle_wrap_enter cpuidle_enter intel_idle However, with --children feature added, it now can show all callees of the entry. For example, "start_kernel" entry now can display it calls rest_init and in turn cpu_idle and then cpuidle_idle_call (95.72%). 6.14% 0.00% swapper [kernel.kallsyms] [k] start_kernel | --- start_kernel rest_init cpu_idle | |--97.52%-- cpuidle_idle_call | cpuidle_enter_tk | | | |--99.91%-- cpuidle_wrap_enter | | cpuidle_enter | | intel_idle | --0.09%-- [...] --2.48%-- [...] Note that start_kernel has no self overhead - meaning that it never get sampled by itself but constructs such a nice callgraph. But, sadly, if an entry has self overhead, callchain will get confused with generated callchain (like above) and self callchains (which reversed order) like the eariler example. To be consistent with other entries, I'd like to make it just to show a single entry - itself - like below since it doesn't have callees (children) at all. But still use the whole callchain to construct children entries (like the start_kernel) as usual. 40.53% 40.53% swapper [kernel.kallsyms] [k] intel_idle | --- intel_idle Note that this is just for --children is enabled. Without that, it will do the original behavior. Cc: Frederic Weisbecker <fweisbec@...il.com> Signed-off-by: Namhyung Kim <namhyung@...nel.org> --- tools/perf/util/hist.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 30df6187ee02..67f249daf34e 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -716,7 +716,28 @@ iter_add_single_cumulative_entry(struct hist_entry_iter *iter, iter->he = he; he_cache[iter->curr++] = he; - callchain_append(he->callchain, &callchain_cursor, sample->period); + if (callchain_param.order == ORDER_CALLER) { + struct callchain_cursor cursor; + int nr = callchain_cursor.nr; + + /* + * When --children with -g caller, it just adds noise to + * self entries. Just adding last node (self) is enough + * and it'd privide a consistent view with other (cumulative) + * entries. + */ + while (--nr) { + callchain_cursor_advance(&callchain_cursor); + } + + BUG_ON(callchain_cursor.nr != callchain_cursor.pos + 1); + + callchain_cursor_snapshot(&cursor, &callchain_cursor); + + callchain_append(he->callchain, &cursor, sample->period); + } else { + callchain_append(he->callchain, &callchain_cursor, sample->period); + } /* * We need to re-initialize the cursor since callchain_append() -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists