linux-kernel - Re: Kernel 3.16.0 USB crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EC8579.1030008@redhat.com>
Date:	Thu, 14 Aug 2014 11:46:33 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Claudio Bizzarri <claudio.bizzarri@...il.com>,
	Matt <jackdachef@...il.com>
CC:	kraxel@...hat.com, sarah.a.sharp@...ux.intel.com,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: Kernel 3.16.0 USB crash

Hi,

On 08/14/2014 10:39 AM, Claudio Bizzarri wrote:
> Ciao,
> 
> thank you very much for replay, you are right: it's UAS module. Now I'm
> using Ubuntu 14.04 with kernel 3.16.1 from
> http://kernel.ubuntu.com/~kernel-ppa/mainline/, there is no /proc/config.gz,
> but but there is a config file in /boot:
> 
> b0@...50ssd:~⟫ grep USB_UAS /boot/config-3.16.1-031601-generic
> CONFIG_USB_UAS=m
> 
> When I attach my external USB disk I've 30 seconds before my laptop freeze,
> here is my dmesg output, disk is not mounted:

Hmm, this sounds like a similar problem we've been having with JMicron UAS
bridges over USB-2.

Can you collect "lsusb -v" output for the drive in question when connected
through an usb-3 port (the uas module does not need to be loaded).

Also can you try the following patch, and see if that makes uas work ? :

diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 511b229..6cdc1b9 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -1033,6 +1033,7 @@ static int uas_configure_endpoints(struct uas_dev_info *devinfo)
 						    3, 256, GFP_NOIO);
 		if (devinfo->qdepth < 0)
 			return devinfo->qdepth;
+		devinfo->qdepth = 32;
 		devinfo->use_streams = 1;
 	}

This is in essence the fix we've done for using these devices with uas over usb-2,
I would have expected this to not be be necessary at superspeed since there the number
of streams the device supports is part of the usb descriptors, but maybe the device
claims to support more streams then it can actually handle.

Note I'm on vacation next week, so don't expect another reply from me in this thread
for at least a week.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/