lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140814145804.GA5586@richard> Date: Thu, 14 Aug 2014 22:58:04 +0800 From: Wei Yang <weiyang@...ux.vnet.ibm.com> To: Liviu Dudau <Liviu.Dudau@....com> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Catalin Marinas <Catalin.Marinas@....com>, Will Deacon <Will.Deacon@....com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Arnd Bergmann <arnd@...db.de>, Russell King <linux@....linux.org.uk>, Tanmay Inamdar <tinamdar@....com>, Grant Likely <grant.likely@...retlab.ca>, Sinan Kaya <okaya@...eaurora.org>, Jingoo Han <jg1.han@...sung.com>, Kukjin Kim <kgene.kim@...sung.com>, Suravee Suthikulanit <suravee.suthikulpanit@....com>, linux-pci <linux-pci@...r.kernel.org>, linux-arch <linux-arch@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Device Tree ML <devicetree@...r.kernel.org>, LAKML <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v9 02/12] PCI: OF: Parse and map the IRQ when adding the PCI device. On Tue, Aug 12, 2014 at 05:25:15PM +0100, Liviu Dudau wrote: >Enhance the default implementation of pcibios_add_device() to >parse and map the IRQ of the device if a DT binding is available. > >Cc: Bjorn Helgaas <bhelgaas@...gle.com> >Cc: Grant Likely <grant.likely@...aro.org> >Cc: Rob Herring <robh+dt@...nel.org> >Signed-off-by: Liviu Dudau <Liviu.Dudau@....com> >--- > drivers/pci/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >index 1c8592b..29d1775 100644 >--- a/drivers/pci/pci.c >+++ b/drivers/pci/pci.c >@@ -17,6 +17,7 @@ > #include <linux/spinlock.h> > #include <linux/string.h> > #include <linux/log2.h> >+#include <linux/of_pci.h> > #include <linux/pci-aspm.h> > #include <linux/pm_wakeup.h> > #include <linux/interrupt.h> >@@ -1453,6 +1454,8 @@ EXPORT_SYMBOL(pcim_pin_device); > */ > int __weak pcibios_add_device(struct pci_dev *dev) > { >+ dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); >+ > return 0; > } Liviu, For this, my suggestion is to add arch dependent function to setup the irq line for pci devices. I can't find an obvious reason this won't work on other archs, but maybe this will hurt some of them? > >-- >2.0.4 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-pci" in >the body of a message to majordomo@...r.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Richard Yang Help you, Help me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists