lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LRH.2.03.1408141209500.14603@AMR> Date: Thu, 14 Aug 2014 12:20:24 -0600 (MDT) From: Keith Busch <keith.busch@...el.com> To: Matias Bjorling <m@...rling.me> cc: Jens Axboe <axboe@...com>, Keith Busch <keith.busch@...el.com>, Matthew Wilcox <willy@...ux.intel.com>, "Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>, LKML <linux-kernel@...r.kernel.org>, linux-nvme <linux-nvme@...ts.infradead.org>, Christoph Hellwig <hch@...radead.org>, Rob Nelson <rlnelson@...gle.com>, Ming Lei <tom.leiming@...il.com> Subject: Re: [PATCH v11] NVMe: Convert to blk-mq On Thu, 14 Aug 2014, Matias Bjorling wrote: >> nr_tags must be uninitialized or screwed up somehow, otherwise I don't >> see how that kmalloc() could warn on being too large. Keith, are you >> running with slab debugging? Matias, might be worth trying. The queue's tags were freed in 'blk_mq_map_swqueue' because some queues weren't mapped to a s/w queue, but the driver has a pointer to that freed memory, so it's a use-after-free error. This part in the driver looks different than it used to be in v8 when I last tested. The nvme_queue used to have a pointer to the 'hctx', but now it points directly to the 'tags', but it doesn't appear to be very safe. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists