linux-kernel - Re: [tip:locking/arch] locking,arch,avr32: Fold atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140814192720.GA16175@samfundet.no>
Date:	Thu, 14 Aug 2014 21:27:20 +0200
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, peterz@...radead.org,
	paulmck@...ux.vnet.ibm.com, hskinnemoen@...il.com,
	tglx@...utronix.de
Subject: Re: [tip:locking/arch] locking,arch,avr32: Fold atomic_ops

Around Thu 14 Aug 2014 10:19:44 -0700 or thereabout, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  d325209b6000dcd13404ee946d2292e15a56718c
> Gitweb:     http://git.kernel.org/tip/d325209b6000dcd13404ee946d2292e15a56718c
> Author:     Peter Zijlstra <peterz@...radead.org>
> AuthorDate: Wed, 9 Apr 2014 21:51:29 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Thu, 14 Aug 2014 12:48:05 +0200
> 
> locking,arch,avr32: Fold atomic_ops
> 
> Many of the atomic op implementations are the same except for one
> instruction; fold the lot into a few CPP macros and reduce LoC.
> 
> This also prepares for easy addition of new ops.
> 
> Requires the asm_op because of eor.
> 
> AVR32 is a bit special in that its ADD/SUB instructions are not
> symmetric. Its SUB instruction allows for an 21bit immediate.

Fantastic, looks great.

Do you have any plans for merge route? I'll happily do it through the avr32
tree, but if it is part of another series, it makes most sense to do it
there.

> Signed-off-by: Peter Zijlstra <peterz@...radead.org>
> Cc: Hans-Christian Egtvedt <egtvedt@...fundet.no>
> Cc: Haavard Skinnemoen <hskinnemoen@...il.com>
> Cc: Hans-Christian Egtvedt <egtvedt@...fundet.no>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Link: http://lkml.kernel.org/r/20140531141445.GD16155@laptop.programming.kicks-ass.net
> Signed-off-by: Ingo Molnar <mingo@...nel.org>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

> ---
>  arch/avr32/include/asm/atomic.h | 123 ++++++++++++++++++++--------------------
>  1 file changed, 62 insertions(+), 61 deletions(-)

<snipp diff>

-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/