lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140814.142307.1009368551221010220.davem@redhat.com> Date: Thu, 14 Aug 2014 14:23:07 -0700 (PDT) From: David Miller <davem@...hat.com> To: hau@...ltek.com Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] r8169:add support for RTL8168H and RTL8107E From: Chun-Hao Lin <hau@...ltek.com> Date: Wed, 13 Aug 2014 23:06:13 +0800 > RTL8168H is Realtek PCIe Gigabit Ethernet controller. > RTL8107E is Realtek PCIe Fast Ethernet controller. > > This patch add support for these two chips. > > Signed-off-by: Chun-Hao Lin <hau@...ltek.com> Please don't break the indentation like you have here: > + rtl_w1w0_eri(tp, > + 0x0dc, > + ERIAR_MASK_0100, > + MagicPacket_v2, > + 0x0000, > + ERIAR_EXGMAC); ... > + rtl_w1w0_eri(tp, > + 0x0dc, > + ERIAR_MASK_0100, > + 0x0000, > + MagicPacket_v2, > + ERIAR_EXGMAC); ... > @@ -4495,15 +4791,19 @@ static void rtl8169_hw_reset(struct rtl8169_private *tp) > tp->mac_version == RTL_GIGA_MAC_VER_31) { > rtl_udelay_loop_wait_low(tp, &rtl_npq_cond, 20, 42*42); > } else if (tp->mac_version == RTL_GIGA_MAC_VER_34 || > - tp->mac_version == RTL_GIGA_MAC_VER_35 || > - tp->mac_version == RTL_GIGA_MAC_VER_36 || > - tp->mac_version == RTL_GIGA_MAC_VER_37 || > - tp->mac_version == RTL_GIGA_MAC_VER_40 || > - tp->mac_version == RTL_GIGA_MAC_VER_41 || > - tp->mac_version == RTL_GIGA_MAC_VER_42 || > - tp->mac_version == RTL_GIGA_MAC_VER_43 || > - tp->mac_version == RTL_GIGA_MAC_VER_44 || > - tp->mac_version == RTL_GIGA_MAC_VER_38) { > + tp->mac_version == RTL_GIGA_MAC_VER_35 || > + tp->mac_version == RTL_GIGA_MAC_VER_36 || > + tp->mac_version == RTL_GIGA_MAC_VER_37 || > + tp->mac_version == RTL_GIGA_MAC_VER_38 || > + tp->mac_version == RTL_GIGA_MAC_VER_40 || > + tp->mac_version == RTL_GIGA_MAC_VER_41 || > + tp->mac_version == RTL_GIGA_MAC_VER_42 || > + tp->mac_version == RTL_GIGA_MAC_VER_43 || > + tp->mac_version == RTL_GIGA_MAC_VER_44 || > + tp->mac_version == RTL_GIGA_MAC_VER_45 || > + tp->mac_version == RTL_GIGA_MAC_VER_46 || > + tp->mac_version == RTL_GIGA_MAC_VER_47 || > + tp->mac_version == RTL_GIGA_MAC_VER_48) { > RTL_W8(ChipCmd, RTL_R8(ChipCmd) | StopReq); > rtl_udelay_loop_wait_high(tp, &rtl_txcfg_empty_cond, 100, 666); > } else { None of these changes are indented correctly, and in the last hunk the original code was perfectly indented and you should have not adjusted it. On a multi-line conditional or function call, the second and subsequent lines should start exactly at the first column after the openning parenthesis of the initial line. You must use the appropriate number of TAB then SPACE characters necessary to achieve this. If you are indenting these lines only using TAB characters, you are doing it incorrectly. Please audit your entire patch for this problem, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists