lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <bbf016f1772245a6a08f92ea8346b8ff@DFM-DB3MBX15-08.exchange.corp.microsoft.com> Date: Thu, 14 Aug 2014 21:32:38 +0000 From: Haiyang Zhang <haiyangz@...rosoft.com> To: David Miller <davem@...hat.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, KY Srinivasan <kys@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>, "jasowang@...hat.com" <jasowang@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "driverdev-devel@...uxdriverproject.org" <driverdev-devel@...uxdriverproject.org> Subject: RE: [PATCH net-next,v2] hyperv: Increase the buffer length for netvsc_channel_cb() > -----Original Message----- > From: David Miller [mailto:davem@...hat.com] > Sent: Thursday, August 14, 2014 5:29 PM > To: Haiyang Zhang > Cc: netdev@...r.kernel.org; KY Srinivasan; olaf@...fle.de; > jasowang@...hat.com; linux-kernel@...r.kernel.org; driverdev- > devel@...uxdriverproject.org > Subject: Re: [PATCH net-next,v2] hyperv: Increase the buffer length for > netvsc_channel_cb() > > From: Haiyang Zhang <haiyangz@...rosoft.com> > Date: Wed, 13 Aug 2014 18:03:44 +0000 > > > When the buffer is too small for a packet from VMBus, a bigger buffer > will be > > allocated in netvsc_channel_cb() and retry reading the packet from > VMBus. > > Increasing this buffer size will reduce the retry overhead. > > > > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com> > > Reviewed-by: Dexuan Cui <decui@...rosoft.com> > ... > > - net_device = kzalloc(sizeof(struct netvsc_device), GFP_KERNEL); > > + net_device = vzalloc(sizeof(*net_device)); > > This isn't what I suggested that you do. > > I said that the buffer inside of netvsc_device should be made an > indirect pointer and thus allocated seperately. > > Thus you're still kzalloc() net_device, but net_device->cb_buffer > becomes "unsigned char *" and another allocation is made for it. I will change the patch to this way. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists