linux-kernel - Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53ED30BD.90403@amd.com>
Date:	Thu, 14 Aug 2014 16:57:17 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...e.de>, Clemens Ladisch <clemens@...isch.de>
CC:	Guenter Roeck <linux@...ck-us.net>, <jdelvare@...e.de>,
	<rdunlap@...radead.org>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>, <dan.carpenter@...cle.com>,
	<lm-sensors@...sensors.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h

On 8/14/2014 4:08 PM, Borislav Petkov wrote:
> On Thu, Aug 14, 2014 at 10:22:31PM +0200, Clemens Ladisch wrote:
>>>> +	depends on X86 && PCI && AMD_NB
>>> Is the added dependency acceptable ?
>> Yes, it is automatically set from CPU_SUP_AMD.
> Well, we can always move that function to k10temp but I'll venture a
> guess that Aravind wants to use it somewhere else too? Correct, Aravind?
>

Actually I don't need it outside of k10temp as of now (or near future)
I added it in amd_nb as that was Clemens, Guenter's suggestion on the 
previous version;
Besides, it made sense as it's an indirect access of NB_SMU register and 
amd_nb seems a good place to put the function in case someone needs it 
in the future.

I can move it locally to k10temp and remove the dependency if that's 
more preferable. Do let me know.

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/