linux-kernel - Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53ED361F.4010009@amd.com>
Date:	Thu, 14 Aug 2014 17:20:15 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...e.de>
CC:	Clemens Ladisch <clemens@...isch.de>,
	Guenter Roeck <linux@...ck-us.net>, <jdelvare@...e.de>,
	<rdunlap@...radead.org>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>, <dan.carpenter@...cle.com>,
	<lm-sensors@...sensors.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h

On 8/14/2014 5:05 PM, Borislav Petkov wrote:
> On Thu, Aug 14, 2014 at 04:57:17PM -0500, Aravind Gopalakrishnan wrote:
>> Actually I don't need it outside of k10temp as of now (or near future)
>> I added it in amd_nb as that was Clemens, Guenter's suggestion on the
>> previous version;
>> Besides, it made sense as it's an indirect access of NB_SMU register and
>> amd_nb seems a good place to put the function in case someone needs it in
>> the future.
> Then someone can move it then. But until that happens it is pretty
> pointless of having the Kconfig dependency just for one small function
> with a single user.
>
>> I can move it locally to k10temp and remove the dependency if that's
>> more preferable.
> Yeah, it looks like a fabricated and not true dependency, which doesn't
> make any sense currently.
>
> Thanks.
>

Ok, Will fix this and send V3.

-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/