linux-kernel - Re: [PATCH] mmc: dw_mmc: Remove architecture dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL1qeaFgySoDs_PWA5FtDK0JQMVoFFfgLbOBz6-dshEg7NCdhQ@mail.gmail.com>
Date:	Wed, 13 Aug 2014 17:13:23 -0700
From:	Andrew Bresticker <abrestic@...omium.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alim Akhtar <alim.akhtar@...il.com>, Chris Ball <chris@...ntf.net>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Doug Anderson <dianders@...omium.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: Remove architecture dependency

> In general, it's best to have specific dependencies on the subsystem
> a driver uses. You probably need something like
>
>         depends on HAS_IOMEM && COMMON_CLK && REGULATOR
>         depends on COMPILE_TEST || ARC || ARM || MIPS
>
> to cover all the possible cases. The specific options are probably
> not the ones I listed above, but you should get the idea. Most importantly,
> you don't want to allow building the driver on architectures on which
> it can't compile.

The only compile-time dependencies I see are HAS_IOMEM (which MMC
already depends on) and HAS_DMA.  There isn't any compile-time
dependency on COMMON_CLK, REGULATOR, GPIOLIB, OF, etc.  I've compiled
it successfully for a few non-ARM/ARC architectures, though that
certainly isn't an exhaustive test.  To be safe though, perhaps I'll
just update the architecture dependency to include MIPS ||
COMPILE_TEST as you suggested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/