linux-kernel - Re: [PATCH V3] hwmon, k10temp: Add support for F15h M60h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EDE4B3.6090903@roeck-us.net>
Date:	Fri, 15 Aug 2014 03:45:07 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>,
	clemens@...isch.de, jdelvare@...e.de, rdunlap@...radead.org,
	bp@...e.de
CC:	lm-sensors@...sensors.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] hwmon, k10temp: Add support for F15h M60h

On 08/14/2014 04:15 PM, Aravind Gopalakrishnan wrote:
> This patch adds temperature monitoring support for F15h M60h processor.
>   - Add new pci device id for the relevant processor
>   - The functionality of REG_REPORTED_TEMPERATURE is moved to
>     D0F0xBC_xD820_0CA4 [Reported Temperature Control]
>     - So, use this to get CUR_TEMP value
>     - Since we need an indirect register access, protect this with
>       a mutex lock
>   - Add Kconfig, Doc entries to indicate support for this processor.
>
> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
> ---
> Changes in V3:
>   - Move helper function that protects indirect register access locally
>     until a time when others outside k10temp may need it
>

Applied, with a small change: I made the mutex and the new function static.
That can be changed if/when needed, and declaring it static now ensures that
we'll notice it. Likely the "next" user won't use the function anyway, but
that is a problem to sort out after it happens.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/