linux-kernel - Re: [PATCH] drm/msm: Fix missing unlock on error in msm_fbdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Aug 2014 20:23:49 -0400
From:	Rob Clark <robdclark@...il.com>
To:	weiyj_lk@....com
Cc:	David Airlie <airlied@...ux.ie>, Hai Li <hali@...eaurora.org>,
	Thierry Reding <treding@...dia.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Dave Airlie <airlied@...hat.com>,
	"Matwey V. Kornilov" <matwey.kornilov@...il.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: Fix missing unlock on error in msm_fbdev_create()

On Wed, Aug 13, 2014 at 9:01 PM,  <weiyj_lk@....com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Add the missing unlock before return from function msm_fbdev_create()
> in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Thanks, I've got it queued up..

BR,
-R

> ---
>  drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index 9c5221c..ab5bfd2 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -143,7 +143,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
>         ret = msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
>         if (ret) {
>                 dev_err(dev->dev, "failed to get buffer obj iova: %d\n", ret);
> -               goto fail;
> +               goto fail_unlock;
>         }
>
>         fbi = framebuffer_alloc(0, dev->dev);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/