linux-kernel - Re: [PATCH] x86_32, entry: Clean up sysenter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrV048o-6nKK3TJXf=mdjARO=KKmbCxAVMYTGPffGNX-vQ@mail.gmail.com>
Date:	Fri, 15 Aug 2014 08:42:30 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Stefan Bader <stefan.bader@...onical.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Roland McGrath <roland@...hat.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH] x86_32, entry: Clean up sysenter_badsys declaration

On Fri, Aug 15, 2014 at 1:57 AM, Stefan Bader
<stefan.bader@...onical.com> wrote:
> commit 554086d85e "x86_32, entry: Do syscall exit work on badsys
> (CVE-2014-4508)" introduced a new jump label (sysenter_badsys) but
> somehow the END statements seem to have gone wrong (at least it
> feels that way to me).
> This does not seem to be a fatal problem, but just for the sake
> of symmetry, change the second syscall_badsys to sysenter_badsys.

Acked-by: Andy Lutomirski <luto@...capital.net>

hpa, can you pick up one of the several variants of this patch that
are floating around?  AFAIK nothing cares about the sizes of these
symbols, but the current code is clearly wrong even if it's harmless.

--Andy

>
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> ---
>  arch/x86/kernel/entry_32.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> index 47c410d..4b0e1df 100644
> --- a/arch/x86/kernel/entry_32.S
> +++ b/arch/x86/kernel/entry_32.S
> @@ -683,7 +683,7 @@ END(syscall_badsys)
>  sysenter_badsys:
>         movl $-ENOSYS,%eax
>         jmp sysenter_after_call
> -END(syscall_badsys)
> +END(sysenter_badsys)
>         CFI_ENDPROC
>
>  .macro FIXUP_ESPFIX_STACK
> --
> 1.9.1
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/