lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Aug 2014 10:13:14 -0600 From: Stephen Warren <swarren@...dotorg.org> To: Nick Dyer <nick.dyer@...ev.co.uk>, Javier Martinez Canillas <javier.martinez@...labora.co.uk>, Dmitry Torokhov <dmitry.torokhov@...il.com> CC: Stephen Warren <swarren@...dia.com>, Yufeng Shen <miletus@...omium.org>, Benson Leung <bleung@...omium.org>, Doug Anderson <dianders@...omium.org>, Olof Johansson <olof@...om.net>, linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example On 08/15/2014 10:08 AM, Nick Dyer wrote: > On 15/08/14 13:01, Javier Martinez Canillas wrote: >>> By passing all these keycodes the touchpad worked as expected for me and the >>> driver did the same than the Chrome OS driver that has these keycodes hardcoded >>> when is_tp is true. >>> >>>> at the protocol guide for T19. >>> >>> I don't have access to proper documentation and I wouldn't expect people to have >>> access to non-public docs in order to use a Device Tree binding. >>> >>> That's why I wanted to document an example, so using this property could be >>> easier for others and they shouldn't have to look at the driver in order to >>> figure it out (and getting it wrong as you said :) ) >>> >>> So it would be great if you could provide an example on how this is supposed to >>> be used. >> >> Any comments on this? I would really appreciate if you can expand on how >> this DT property is supposed to be used so I can re-spin the atmel support >> patch for Peach boards. > > The below patch improves the documentation for the gpio-property. That patch makes sense, and is a nice description, Acked-by: Stephen Warren <swarren@...dia.com> > diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt > Example: > > touch@4b { > Perhaps it makes sense to add a linux,gpio-keymap property into the example too though; IIRC there was an earlier patch to the docs that did this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists