linux-kernel - Re: [PATCH] blk-mq: fix WARNING "percpu_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EE534F.2040208@kernel.dk>
Date:	Fri, 15 Aug 2014 12:37:03 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <ming.lei@...onical.com>, linux-kernel@...r.kernel.org
CC:	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] blk-mq: fix WARNING "percpu_ref_kill() called more than
 once!"

On 2014-08-15 09:16, Ming Lei wrote:
> Before doing queue release, the queue has been freezed already
> by blk_cleanup_queue(), so needn't to freeze queue for deleting
> tag set.
>
> This patch fixes the WARNING of "percpu_ref_kill() called more than once!"
> which is triggered during unloading block driver.

Thanks, you are right, we need not call it there. I'll apply this for 3.17.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/