linux-kernel - Re: [PATCH 1/1] mmc: core: Use regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140816125903.GC28623@sirena.org.uk>
Date:	Sat, 16 Aug 2014 13:59:03 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Tim Kryger <tim.kryger@...il.com>,
	Chris Ball <chris@...ntf.net>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	Haijun Zhang <Haijun.Zhang@...escale.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Yuvaraj Kumar C D <yuvaraj.cd@...il.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask
 is empty.

On Fri, Aug 15, 2014 at 04:51:38PM +0200, Ulf Hansson wrote:

> Just wanted to add some input regarding the errors in the mmc case.
> These are of high importance. In principle if you get, "Failed getting
> OCR mask: -22", likely you will be using a wrong OCR mask while
> negotiating the voltage level with the card.

> So, somehow we need to address this issue.

Perhaps a WARN_ON() would help here - I'd not blame users for just
ignoring the current warning?

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)